Skip to content

Fix queries always being created in qlpack root#3044

Merged
koesie10 merged 1 commit intomainfrom
koesie10/fix-query-storage-path
Nov 1, 2023
Merged

Fix queries always being created in qlpack root#3044
koesie10 merged 1 commit intomainfrom
koesie10/fix-query-storage-path

Conversation

@koesie10
Copy link
Copy Markdown
Member

@koesie10 koesie10 commented Nov 1, 2023

This passes through the query storage path to the qlpack generator so it's able to create the query in the correct selected folder.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

This passes through the query storage path to the qlpack generator so
it's able to create the query in the correct selected folder.
@koesie10 koesie10 marked this pull request as ready for review November 1, 2023 14:33
@koesie10 koesie10 requested review from a team as code owners November 1, 2023 14:33
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks ✨

@koesie10 koesie10 merged commit b47c561 into main Nov 1, 2023
@koesie10 koesie10 deleted the koesie10/fix-query-storage-path branch November 1, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants